Add a flag to remove the wasm name section #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a `--remove-name-section` flag to the `wasm-bindgen` command which will remove the `name` section of the wasm file, used to indicate the names of functions typically used in debugging. This flag is off-by-default and will primarily be controlled by wasm-pack, typically being passed by default with `wasm-pack build --release`. Closes rustwasm#1021
sendilkumarn
approved these changes
Nov 9, 2018
|
Unfortunately we don't have many tests for wasm-bindgen's CLI today, but this'll get tested soon through wasm-pack so I'm gonna go ahead and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a
--remove-name-sectionflag to thewasm-bindgencommand which will remove the
namesection of the wasm file, used toindicate the names of functions typically used in debugging. This flag
is off-by-default and will primarily be controlled by wasm-pack,
typically being passed by default with
wasm-pack build --release.Closes #1021